Pick one up by the handles before anything else and you can tell straight away. A good gym bag has a bit of structure to it even when it's empty, enough that it stands up on a changing room bench rather than slumping into a puddle of nylon, and the zip pulls should feel chunky under your fingers, not like they'll snap off the first time you're late and yanking them shut over trainers and a wet swimsuit. The straps matter too, a flat webbing strap that doesn't fold in half and dig a groove into your shoulder is worth more than any amount of clever pocket design.
In an ordinary week this thing ends up doing jobs that have nothing to do with the gym, which is why I'd rather it looked like a normal bag than a walking advert for a fitness brand. It needs to sit happily next to a desk, go on the back seat of a car without tipping its contents everywhere on a roundabout, and not look mad slung over a coat on a Tuesday when you're going straight from work to a class. The ones with a separate shoe compartment or a vented pocket for sweaty kit are genuinely useful rather than a gimmick, because nobody wants their work bag smelling like a changing room by Thursday, and a side pocket that actually fits a water bottle without you fighting it every single time saves more irritation than it has any right to.
Colour wise, I've learned to stop buying anything pale after one memorable incident with a leaking shampoo bottle and a bag the colour of clotted cream that never fully recovered. Black is the obvious safe choice and it earns that reputation honestly, it hides scuffs from being dropped on gym floors and doesn't show every mark from a damp yoga mat strapped to the side. A deep navy or a khaki does the same job while looking slightly less like you're off to do actual manual labour, and if you want colour at all, get it in something washable rather than a fabric that holds a stain the moment a banana explodes in the bottom, because it will, eventually, it always does.
If you've got none of these and need to start somewhere, go for a mid size holdall in a wipeable material, something between a weekend bag and a tote, with a shoe pocket and a decent cross body strap option as well as handles. Skip the tiny trendy ones that look lovely on a hanger and fit precisely a towel and nothing else, and skip the enormous ones too, because you will fill the extra space with things you don't need and then wonder why your shoulder aches on the walk home. Somewhere in the middle, soft enough to squash under a desk, sturdy enough to survive being thrown in a boot, is the one that quietly gets used every single week without you ever really thinking about it.