I tried one on expecting to look like someone in a period drama and instead looked like I was smuggling two bread rolls under my arms, which tells you the puff sleeve thing is a lottery rather than a guaranteed win. When it works, though, it really works, that moment of putting it on and suddenly having shoulders like you mean business, a bit of drama before you've even picked an occasion to wear it to.
Sizing is where most people come unstuck, because the sleeve is doing so much work that brands often assume the rest of the dress should be small to compensate, so you end up with a bodice that pulls across the chest while the arms balloon out like they're a separate decision made by a separate person. Try the arm movement before anything else, reach forward like you're picking something off a table, reach up like you're on a bus holding a rail, because a puff sleeve that looks lovely standing still can trap your arms completely the second you move them. If the seam at the top of the sleeve sits right on the edge of your shoulder rather than slightly past it, it will dig in within the hour. Go up a size in the body if you have to and ignore what that does to your usual label loyalty, nobody checks the tag once you're wearing it.
The gap between a good one and a sad one is almost always in how the sleeve is held up. A proper one has some structure inside, a bit of stiffened lining or a decent gather, so the puff stays put through a whole evening rather than slowly deflating like a balloon the day after a party. The cheap version uses thin fabric and elastic alone, which looks fine in a changing room mirror and then goes flat and creased the second you sit down for longer than ten minutes. Check the cuff too, a tight elastic cuff on a flimsy sleeve will leave a red mark and look like a rash by the time you're home.
Keep the rest of the outfit quiet, because the sleeves are already shouting. A big statement necklace or a chunky cardigan on top just adds bulk exactly where you don't need it, plain flats or simple heels and minimal jewellery let the shape do what it's meant to. Skip the fitted blazer too, the shoulder lines fight each other and you end up looking like you're wearing two different decades at once.
Where it genuinely isn't the right choice is anything involving sustained arm work, carrying bags on public transport, holding a toddler, or a long day where you need to forget what you're wearing. For those days, buy something with a normal sleeve and save the puff for when standing around looking good is actually the job.
Short sleeve dresses are worth a look too.