For years I thought straight leg meant shapeless, a sort of denim tube that did nothing for anyone who wasn't six foot and built like a pencil. What changed my mind was a pair that actually had a waist in them, a proper curved yoke at the back rather than a flat strip of fabric, so they followed the shape of a hip instead of just hanging off it. That's when straight leg stopped being the jeans I avoided and became the ones I reach for when skinny jeans feel too try hard and wide leg feels like I'm wearing a tent.
A good pair sits well with almost everything plain, because the leg line is doing enough on its own. A fitted jumper tucked in, a longline blazer, a plain white trainer or a heeled boot depending on the day. Where the cheap versions catch you out is in the details you don't notice until the fourth wear: a zip that starts to sit proud after a few washes, a button that's clearly just glued rather than properly set, belt loops that are already pulling away from the waistband. A decent pair has weight to the denim, a bit of structure that doesn't go limp by lunchtime, and stitching on the seams that's even rather than wandering. Rub the inside seam between your fingers before you buy, if it feels thin and papery, it'll wear through at the thigh within a season, and nobody wants a hole appearing somewhere that embarrassing.
Fit is where most people, including me for a long while, get it wrong twice before getting it right. Straight leg should skim rather than hug all the way down, no tightness at the knee and no flare at the ankle, that's a different jean entirely. The waist is the thing to get obsessive about, because if it gapes at the back when you sit down, that's not something a belt fixes long term. Try sitting in them in the changing room, not just standing side on in the mirror. Length is its own project on me, there's no pretending otherwise, and a straight leg that's meant to break at the shoe will usually need an inch or two off unless I'm wearing a proper heel.
The best bit of a decent pair is what happens after a few months. The denim softens at the knee and the crease in front of the hip without going saggy, it starts to look like it's actually been worn by a person rather than fresh off a rail, and that's exactly when they become the ones you grab without thinking.