The pencil skirt spent a good decade being treated as office armour, the thing you put on when you wanted to look like you had your life together even if you didn't, and I think it's had a quiet rethink since. It's looser through the hem than it used to be, the vents are more generous, and it's turned up in fabrics that have nothing to do with a boardroom. Mostly that's an improvement. A shape built entirely around restriction was never going to suit the way most of us actually move.
What separates a good one from a sad one is almost always the lining and the seam at the back vent. A skirt in proper ponte or a wool blend with some structure will hold its shape across a day of sitting down and standing up, whereas a thin stretch cotton one will bag at the knees by lunchtime and never quite recover. Check the vent itself, because a cheap one is stitched down too far and barely opens, which sounds minor until you're trying to get up a flight of stairs and taking tiny, undignified steps to do it. Good hardware, if there's a zip on show, sits flat and doesn't pull at the seam either side. A proper waistband, with a bit of grosgrain tape inside it, keeps its shape wash after wash, while a flimsy one rolls over by the third wear.
Fit lives and dies at the hip and the hem. You want ease across the hip bone, not just the waist, because a pencil skirt that's tight at the waist and gaping at the back means you've bought the wrong size and your body's shape doesn't match the pattern's assumptions, not the other way round. The hem should sit at or just below the knee, where it can still bend when you climb stairs, rather than an inch above, where every step becomes a small negotiation. Walk in it before you buy it if you can, properly walk, not shuffle.
It's a poor choice for anything involving actual movement over distance, a long walk, a bike, a day on your feet in a job that isn't desk based. It's also not forgiving after a big meal, which is worth knowing before a long lunch. I'd avoid pairing it with anything equally fitted on top, a tight knit or a structured blazer that's too sharp, because the whole outfit ends up looking like it's holding its breath. It was never built for a hill, and it still isn't.
For more in this vein, try yellow skirts.