The mistake is packing for the holiday you wish you were going on rather than the one you've actually booked. A week of city walking in linen trousers that need ironing after every wash, or four swimsuits and nothing to wear to dinner, and you end up living in the one outfit that actually works while the rest sits in the case getting creased for nothing. Holiday clothes need to earn their space in a carry on, not just look good on the first morning.
The useful pieces are the ones that do double duty with what you already own rather than needing a whole new wardrobe built around them. A simple dress works over a swimsuit at midday and with sandals and a bit of jewellery by evening, and a linen shirt that covers shoulders on a boat trip also covers a slightly too pink back three days later. Think about what the actual week looks like: a beach holiday wants things that dry fast and don't cling when damp, a city break in high summer wants fabric that breathes and doesn't need much thought after a long day of walking, and anything in shoulder season needs a layer that can go over a dress when the evening turns. Before you buy, check what happens to the fabric creased in a case for six hours, because some linen blends relax out in an hour and others need a hotel iron and a lot of patience you won't have on day one. Check linings too, plenty of lightweight dresses are see through in direct sun and you won't know until you're stood on a beach in it. Pockets are rarer than they should be in summer clothes and worth seeking out if you don't want to carry a bag everywhere. For sizing, go by how the piece sits when you're warm and slightly swollen from heat and flights, not how it fits in a cool shop changing room, and watch waistbands on anything elasticated, as they can dig in after a big lunch in a way that ruins an afternoon. Buy a size that allows for that rather than one that only works first thing in the morning.
Favour pieces that pack flat, don't need much more than a shake out, and work across at least two kinds of day, because the ones that only do one job are the ones you'll wear once and photograph twice. Reach for this kind of thing the week before you fly, when you're deciding what actually earns a spot in the case rather than what just looked nice on a hanger in May.