The one that catches people out every time is the lining going first, stretched soft and see through at the bum long before the fabric on top shows any wear, so you get a shock in good light on holiday number two. It still feels worth the bother, because a decent one piece does more for your shape and your confidence than almost anything else you could pack, and you only need the one.
Where it falls short is anywhere you need to get in and out quickly, a swim lesson with a toddler, a shower afterwards at the gym, a loo visit at a lido when you're already cold and your hands aren't working properly. All that fabric has to come off and go back on again, and wet lycra does not want to cooperate. It is also not the easiest thing to look relaxed in if you're after sunbathing all day rather than actually swimming, since the coverage that makes it so good in water can feel a bit much lying still for six hours. Chlorine is the real enemy though, more than sun or sand. A cheap one will go baggy at the straps and faded at the front within a couple of weeks of regular pool use, while a well made one in a proper swim fabric will hold its shape and colour through a whole season of actual lengths, not just lying about. Washing it out properly after every wear, even a quick rinse in the sink, makes a bigger difference than anything written on the label.
As for colour, plain dark shades, navy, bottle green, a deep plum, are the easiest to live with because they don't show the fade first and they don't go translucent in strong light the way pale colours sometimes do when wet. A print is lovely for a week away but harder to keep wearing once the colours start to soften, so I'd save bold prints for something you're happy to retire after one proper summer rather than something you want to keep reaching for. For occasion, this is your swimming pool, your actual sea swim, your week away where you're in and out of the water rather than posing beside it. For pure lying around, something with less structure might suit you better, but for doing laps, for a lake, for anything active, this is the one that stays put and does the job without you thinking about it.
Would I still want to wear this at the end of a long hot summer, straps stretched a bit, colour a shade softer, or does it only look right brand new?
If you're still deciding, have a look at one piece swimsuits too.