The one thing that matters before anything else: loafers only look good if the fit is snug at the heel and slightly roomy at the toe, because they're built to slip on, not lace up, and if they're loose everywhere you'll be shuffling rather than walking.
Colour wise, I'd always start with something in brown or black before touching a bold finish, because those two go under trousers, under a skirt, under a dress, and don't fight with anything in a bag or belt. Tan is lovely but it's fussier than people assume, it wants to match rather than contrast, so it's a second or third pair rather than a first. Patent is the one to be careful with, it photographs well but shows every scuff within weeks, and a croc or snake finish reads more interesting in low light than it does under an office strip light. If you want one slightly more fun version, go for a deep burgundy or a bottle green rather than anything metallic, they still read as classic but they lift an outfit without shouting about it.
If someone owns none of these, the starting point is a simple leather loafer with a low, almost flat heel and a rounded toe, in brown or black, no tassels or chains or anything that dates it to a particular year. It's the version that works with jeans on a cold February afternoon, with a midi skirt in that awkward bit of spring when it's not warm enough for sandals, and with trousers for most of the working year. Fit is where this goes wrong for people. The classic mistake is buying a size up because the shop pair felt tight on the toes, and ending up with heel slip that rubs within a single wear, because loafers don't have laces to adjust for that. You want them snug enough that your foot doesn't travel backwards when you walk, and if there's a gap at the heel, that's the signal to size down rather than up, whatever the toe feels like standing still in a shop. A thin sock or a heel grip solves a lot of borderline cases rather than a whole size change.
They're at their best from autumn through to a dry spring, less good once the weather turns properly wet, since most pairs aren't built for standing water and suede gives up on the first proper downpour.
Loafers suit anyone who wants to look like they've made an effort without looking like they tried particularly hard that morning.